Skip to content

CODEOWNERS: Add maintainers explicitly #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
golowanow merged 1 commit into from
Mar 13, 2025
Merged

CODEOWNERS: Add maintainers explicitly #1261

golowanow merged 1 commit into from
Mar 13, 2025

Conversation

@golowanow
Copy link
Member

@golowanow golowanow commented Mar 12, 2025

Add maintainers as code owners explicitly to resolve 'unknown owner' error which appears in forks.

@golowanow
CODEOWNERS: Add maintainers explicitly
5e08e74 
Add maintainers as code owners explicitly to resolve
'unknown owner' error which appears in forks.

Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
@golowanow golowanow marked this pull request as ready for review March 12, 2025 12:19
@golowanow golowanow requested a review from a team as a code owner March 12, 2025 12:19
@golowanow golowanow requested review from lgirdwood and marc-hb March 12, 2025 12:20
@lgirdwood
Copy link
Member

lgirdwood commented Mar 12, 2025

@marc-hb if you are still interested pls approve, if not we can remove your name from the PR.

marc-hb
marc-hb approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I don't mind the notifications, there are not that many :-) I will remove myself if that changes.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 12, 2025

Add maintainers as code owners explicitly to resolve 'unknown owner' error which appears in forks.

The change LGTM but I don't understand and I'm curious about this GitHub error message... could you elaborate and do you have an example you can share?

@golowanow
Copy link
Member Author

golowanow commented Mar 12, 2025

I'm curious about this GitHub error message... could you elaborate and do you have an example you can share?

well, an example is this PR itself - currently it shows only the test-maintainers group as the CODEOWNER's owner (and myself as the group member). GH should also show a error here if there is an owner which doesn't exist or have no access to the repo.

image

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 12, 2025

... to resolve 'unknown owner' error which appears in forks.

GH should also show a error here if ...

These look like two different issues. Nevermind.

@golowanow golowanow merged commit 4d97855 into thesofproject:main Mar 13, 2025
6 of 8 checks passed
@golowanow golowanow deleted the codeowners_20250312 branch March 13, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@marc-hb marc-hb marc-hb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@golowanow @lgirdwood @marc-hb