-
Notifications
You must be signed in to change notification settings - Fork 59
ALSABAT: Added Alsabat mixer settings for PTL-SDW-RT712 #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…DW RT712 Signed-off-by: Hariprasad Rajendra <hariprasad.rajendra@intel.com>
|
Can one of the admins verify this patch?
|
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harajend this is good for now, but long term we will have these settings in the UCM for each SKU.
Btw it looks like you have added an empty file ?
gbarkadiusz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@lgirdwood, I only added executable permission to the 'PTLP_RVP_SDW.sh' file, so it is showing as 'Empty file'. Earlier, this file did not have executable permission, so the SOF-Test framework threw some warnings during the test run |
That's a funny GitHub bug! GitHub means "Empty diff" but shows "Empty file" instead. It would of course have been less confusing with a separate commit and commit message :-)
This is an sof-test bug, can you file it? Tests should either apply the settings they find, or the tests should fail. Failure to apply ALSA settings should never be a "warning". |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@golowanow pls review/merge
No description provided.