Skip to content

Conversation

@harajend
Copy link
Contributor

No description provided.

…DW RT712

Signed-off-by: Hariprasad Rajendra <hariprasad.rajendra@intel.com>
@harajend harajend requested a review from a team as a code owner March 10, 2025 07:55
@sofci
Copy link
Collaborator

sofci commented Mar 10, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harajend this is good for now, but long term we will have these settings in the UCM for each SKU.
Btw it looks like you have added an empty file ?

Copy link
Contributor

@gbarkadiusz gbarkadiusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@harajend
Copy link
Contributor Author

@harajend this is good for now, but long term we will have these settings in the UCM for each SKU. Btw it looks like you have added an empty file ?

@lgirdwood, I only added executable permission to the 'PTLP_RVP_SDW.sh' file, so it is showing as 'Empty file'. Earlier, this file did not have executable permission, so the SOF-Test framework threw some warnings during the test run

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 10, 2025

I only added executable permission to the 'PTLP_RVP_SDW.sh' file, so it is showing as 'Empty file'.

That's a funny GitHub bug! GitHub means "Empty diff" but shows "Empty file" instead.

It would of course have been less confusing with a separate commit and commit message :-)

Earlier, this file did not have executable permission, so the SOF-Test framework threw some warnings during the test run

This is an sof-test bug, can you file it? Tests should either apply the settings they find, or the tests should fail. Failure to apply ALSA settings should never be a "warning".

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@golowanow pls review/merge

@golowanow golowanow merged commit 4811444 into thesofproject:main Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants