Test-case: check-audio-equalizers: Updates for IPC4 systems #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
reviewed
Feb 28, 2025
singalsu
force-pushed
the
check_audio_equalizer_update
branch
from
3a4e221 to
bb26b2b
Compare
lgirdwood
approved these changes
Mar 3, 2025
marc-hb
reviewed
Mar 3, 2025
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
This single, missing line is totally unrelated to your PR but it does get rid of most shellcheck warnings! Please add it.
--- a/test-case/check-audio-equalizer.sh
+++ b/test-case/check-audio-equalizer.sh
@@ -18,6 +18,7 @@ set -e
# source from the relative path of current folder
my_dir=$(dirname "${BASH_SOURCE[0]}")
+# shellcheck source=case-lib/lib.sh
source "$my_dir"/../case-lib/lib.sh
OPT_NAME['t']='tplg' OPT_DESC['t']="tplg file, default value is env TPLG: $TPLG"
marc-hb
reviewed
Mar 3, 2025
singalsu
force-pushed
the
check_audio_equalizer_update
branch
from
bb26b2b to
d53bb77
Compare
lgirdwood
approved these changes
Mar 4, 2025
marc-hb
reviewed
Mar 4, 2025
marc-hb
reviewed
Mar 4, 2025
marc-hb
reviewed
Mar 4, 2025
singalsu
force-pushed
the
check_audio_equalizer_update
branch
from
d53bb77 to
7c7458c
Compare
marc-hb
reviewed
Mar 5, 2025
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Code style LGTM. I didn't review the logic!
Member
|
@golowanow good for you ? |
Member
I'm looking through it repeating ci checks. |
golowanow
reviewed
Mar 14, 2025
This changes improves testing time with current topologies from over two minutes to less than one minute. The test signal is zero PCM codes and the playback output is not analyzed. Shorter ne second playback is sufficient to check that aplay and arecord work with the applied EQ configuration. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This addition helps shellcheck to find the test cases library and should avoid plenty of warnings printed. Also the shellcheck and pylint runs-on are updated to Ubuntu 24.04 in Github workflow. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch moves the helper function has_wname_prefix() from topo_vol_kcontrols.py to tplgtool2.py. It will be used by a new script to find bytes controls. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch updates the test check-audio-equalizer.sh to work with IPC4 topologies with different naming for controls. The control name no more includes the component name, so the search for controls is changed. A tool topo_effect_kcontrols.py is used to find bytes controls for given component. The blobs to test with sof-ctl are updated from SOF git repository. The ipc3 or ipc4 directory is chosen based on runtime check of DUT ipc version. The sof-ctl usage is changed. The control is now referenced with the text control name instead of numid. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
check_audio_equalizer_update
branch
from
7c7458c to
fc45722
Compare
golowanow
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the test check-audio-equalizer.sh to work with IPC4 topologies with different naming for controls. The control name no more includes the component name, so the search for controls is changed. A tool topo_effect_kcontrols.py is used to find bytes controls for given component.
The blobs to test with sof-ctl are updated from SOF git repository. The ipc3 or ipc4 directory is chosen based on runtime check of DUT ipc version.
The sof-ctl usage is changed. The control is now referenced with the text control name instead of numid.