Skip to content

Conversation

@harajend
Copy link
Contributor

ignore ISH firmware missing error in PTL since it is not impact to audio test cases

@harajend harajend requested a review from a team as a code owner February 20, 2025 10:05
@sofci
Copy link
Collaborator

sofci commented Feb 20, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

ignore ISH firmware missing error in PTL since it is not impact to audio test cases

Signed-off-by: Hariprasad, Rajendra <hariprasad.rajendra@intel.com>
@harajend harajend force-pushed the fix/verify-kernel-boot-log branch from 7a1f96c to 50fd4d5 Compare February 20, 2025 16:19
@cgturner1 cgturner1 merged commit 4f9592d into thesofproject:main Feb 20, 2025
3 checks passed
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note there was already some ISH ignore in this regex. No one noticed because its size is growing totally out of control. That's why it's now possible to add exclusions on a per device basis.

I wonder how long before this hits some maximum command line or regex size limit...

@golowanow
Copy link
Member

btw, is this error specific to ptl or is it on all platforms ?

@marc-hb
Copy link
Collaborator

marc-hb commented Feb 20, 2025

In my experience, this type of error is specific to... "the latest platform still under development" :-)

The ISH for PTL is probably still under development AND there is always a lag between internal and external releases - same as with SOF and everything else.

The "fix" is to be more aggressive and deploy internal releases on test devices, see discussion in internal issues 596, 572 and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants