Skip to content

ASoC: SOF: Intel: reset SPIB in hda_data_stream_cleanup #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bardliao wants to merge 2 commits into
base: topic/sof-dev
Choose a base branch
from
+10 −5
Open

ASoC: SOF: Intel: reset SPIB in hda_data_stream_cleanup #5718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c812b
ASoC: SOF: Intel: reset spib_addr before disabling SPIB
bardliao May 20, 2026
e5bb265
ASoC: SOF: Intel: Disable SPIB in both direction
bardliao May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions sound/soc/sof/intel/hda-stream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,18 @@ int hda_dsp_stream_spib_config(struct snd_sof_dev *sdev,

mask = (1 << hstream->index);

/* Reset the spib_addr before disabling SPIB */
if (!enable)
sof_io_write(sdev, hstream->spib_addr, 0);

/* enable/disable SPIB for the stream */
snd_sof_dsp_update_bits(sdev, HDA_DSP_SPIB_BAR,
SOF_HDA_ADSP_REG_CL_SPBFIFO_SPBFCCTL, mask,
enable << hstream->index);

/* set the SPIB value */
sof_io_write(sdev, hstream->spib_addr, size);
if (enable)
sof_io_write(sdev, hstream->spib_addr, size);

return 0;
}
Expand Down Expand Up @@ -1324,11 +1329,11 @@ int hda_data_stream_cleanup(struct device *dev, struct snd_dma_buffer *dmab,
struct snd_sof_dev *sdev = dev_get_drvdata(dev);
struct hdac_stream *hstream = hdac_stream(hext_stream);
int sd_offset = SOF_STREAM_SD_OFFSET(hstream);
int ret = 0;
int ret;

if (hstream->direction == SNDRV_PCM_STREAM_PLAYBACK)
ret = hda_dsp_stream_spib_config(sdev, hext_stream, HDA_DSP_SPIB_DISABLE, 0);
else
ret = hda_dsp_stream_spib_config(sdev, hext_stream, HDA_DSP_SPIB_DISABLE, 0);

if (hstream->direction == SNDRV_PCM_STREAM_CAPTURE)
snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, sd_offset,
SOF_HDA_SD_CTL_DMA_START, 0);

Expand Down
Loading