fix(parser): support bash-style single-quote splices in values#633
Open
simoncraf wants to merge 1 commit intotheskumar:mainfrom
Open
fix(parser): support bash-style single-quote splices in values#633simoncraf wants to merge 1 commit intotheskumar:mainfrom
simoncraf wants to merge 1 commit intotheskumar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for bash-style single-quote splices inside
.envvalues.Before this change,
python-dotenvfailed to parse values like:Even though this is valid Bash and evaluates to:
I'm a studentAfter this change,
python-dotenvaccepts that form and parses it correctly.Closes #544
What changed
'"'"'splice pattern while parsing single-quoted values\'handling unchangeddotenv_valuescoverage for the same behaviourExample
This now works:
and is parsed as:
Notes
This change is intentionally narrow in scope.
It does not try to implement general shell-style concatenation. It only supports the specific splice form commonly used in Bash to embed a literal single quote inside an otherwise single-quoted string.