fix: Ensure unmatched optional capture group is treated as null in parseRowColumnSelection#578
Open
zigzagdev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What I have done
PREG_UNMATCHED_AS_NULLflag to thepreg_matchcall inparseRowColumnSelection()''(empty string) rather than leaving them absent, causing$found['end'] ?? nullto return''instead ofnullrow=1,col=2) to always fail validation when combined with semicolon-separated expressions (e.g.row=1;3,col=1;3)Where I have changed
src/FragmentFinder.php: AddPREG_UNMATCHED_AS_NULLtopreg_matchand simplify$endassignment from$found['end'] ?? nullto$found['end']src/TabularDataReaderTestCase.php: Add test cases covering following casesrow=1;3,col=1;3)row=1;3-5)row=0;0)matchingFirstreturns partial results,matchingFirstOrFailthrowsFragmentNotFoundTest Plan
row=1;3row=1;3-5col=1;3row=0;0nullfrommatchingFirstand throw frommatchingFirstOrFailrow=0;3(×2)matchingFirstreturns only the valid result whilematchingFirstOrFailthrowsFragmentNotFoundTest Cases Result