[feature] Allow custom RestClientOptions in DigestAuthenticator to configure internal RestClient #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables injecting custom RestClientOptions into DigestAuthenticator, allowing full control over the internal RestClient used during the digest handshake. It provides flexibility to configure SSL validation, proxies, and other client-specific settings without creating authentication loops. - Added optional RestClientOptions parameter to DigestAuthenticator - Passed RestClientOptions through DigestAuthenticatorManager - Ensured backward compatibility (default behavior remains unchanged)"
Added unit test VerifyHandshakeUsesInjectedClientOptions to ensure DigestAuthenticator correctly applies injected RestClientOptions (tested via Proxy callback) during the digest handshake request.
Collaborator
|
LGTM. Hello @simonabler, apologies for the delay. I plan to proceed with the merge later this week. Thank you again for your support and contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the internal RestClient created by the DigestAuthenticatorManager does not allow any customization of settings like SSL validation, timeouts, or proxies.
Specifically, using the existing RestClient (that includes the authenticator itself) isn't viable, as it creates an endless authentication loop.
Solution
Allow injecting a custom RestClientOptions instance into the DigestAuthenticator.
These options will be applied to the internally created client used for the digest handshake.
This approach provides flexibility (e.g., bypassing SSL checks) without affecting the main client.
Changes introduced:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration