Switch Profile Between Learner & Instructor #2312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazedul-haque
approved these changes
Jan 16, 2026
| { | ||
| onSuccess: (res: AjaxResponse) => { | ||
| window.TutorCore.toast.success(res?.message); | ||
| setTimeout(() => { |
Collaborator
There was a problem hiding this comment.
Why this delay? In production ajax calls usually takes longer times.
harunollyo
requested changes
Jan 16, 2026
| } | ||
|
|
||
| $switch_mode = ''; | ||
| $current_mode = Input::post( 'current_mode' ); |
Collaborator
There was a problem hiding this comment.
The variable name is confusing because the user already has a current mode.
Use switch_mode to clearly indicate the target mode.
Collaborator
There was a problem hiding this comment.
$switch_mode = Input('switch_mode' );
$profile_mode = self::VIEW_AS_STUDENT === $switch_mode ? self::VIEW_AS_STUDENT : self::VIEW_AS_INSTRUCTOR;
update_user_meta( $user_id, self::VIEW_MODE_USER_META, $profile_mode );| $is_instructor = self::is_instructor( $user_id, true ); | ||
| $is_admin = self::is_admin( $user_id ); | ||
|
|
||
| $default_mode = $is_instructor || $is_admin ? self::VIEW_AS_INSTRUCTOR : self::VIEW_AS_STUDENT; |
Collaborator
There was a problem hiding this comment.
To check multiple condition for ternary use ( )
$default_mode = ( $is_instructor || $is_admin ) ? self::VIEW_AS_INSTRUCTOR : self::VIEW_AS_STUDENT;
b-l-i-n-d
requested changes
Jan 16, 2026
Collaborator
There was a problem hiding this comment.
Instead of defining a new interface, use TutorMutationResponse
To me, it seems sensible to keep things together for a single mutation. Co-authored-by: Fahim Faisal <42368238+b-l-i-n-d@users.noreply.github.com>
…o profile-switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch profile to learner/instructorAjaxResponseadded