SvgIcon component added for SVG icon rendering #2302
+216
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the SvgIcon class, providing a fluent builder for rendering SVG icons with customizable attributes, size, and name. This component loads SVG files from the assets directory and supports additional HTML attributes for flexible usage.
Introduces a new 'color' property and method to SvgIcon, allowing icons to be rendered with different color classes. Updates the render logic to append the color class if specified.
harunollyo
requested changes
Jan 9, 2026
| * | ||
| * Example usage: | ||
| * ``` | ||
| * SvgIcon::make() |
Collaborator
There was a problem hiding this comment.
We have simple helper, which support all
tutor_utils()->render_svg_icon( Icon::CHECK );
Collaborator
There was a problem hiding this comment.
This additional class will not add value, rather than make increase codebase and inconsistent code use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.