Skip to content

Conversation

@MGREMY
Copy link
Collaborator

@MGREMY MGREMY commented Jul 20, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Docs have been added/updated (for bug fixes/features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI-related changes
  • Documentation content changes
  • Other... Please describe:

Issue Number

Issue Number: N/A

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated horizontal scrolling behavior for tab lists so that scrollbars now only appear when needed, improving visual appearance.

@vercel
Copy link

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-angular ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2025 11:55pm
flowbite-angular-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2025 11:55pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 20, 2025

Walkthrough

The update modifies the base CSS class in the host theme of flowbiteTabListTheme, changing its horizontal overflow behavior from always displaying a scrollbar to only showing it when necessary. No other logic or exported entity was altered.

Changes

File(s) Change Summary
libs/flowbite-angular/tab/src/tab-list/theme.ts Changed overflow-x-scroll to overflow-x-auto in the base class of the host theme.

Poem

A gentle tweak to overflow,
Now scrollbars only sometimes show.
Tabs glide with ease, not always wide,
A smoother look, a tidier ride.
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93589c3 and 9523192.

📒 Files selected for processing (1)
  • libs/flowbite-angular/tab/src/tab-list/theme.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: MGREMY
PR: themesberg/flowbite-angular#88
File: libs/flowbite-angular/navbar/navbar.component.ts:99-99
Timestamp: 2024-12-11T09:25:50.819Z
Learning: In `libs/flowbite-angular/navbar/navbar.component.ts`, the `NavbarContentComponent` was already required because the `verify` function threw an error if `navbarContentChild` was undefined or null. Therefore, changing `contentChild` to `contentChild.required` does not introduce a breaking change.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#111
File: apps/docs/docs/components/sidebar/directive/_multi-level.component.html:0-0
Timestamp: 2025-01-23T16:05:19.849Z
Learning: The SidebarComponent in flowbite-angular internally generates the `<ul>` element to wrap sidebar items. When using `<aside>` for a sidebar, adding `<nav>` is redundant as `<aside>` already provides appropriate semantic context.
libs/flowbite-angular/tab/src/tab-list/theme.ts (8)
Learnt from: MGREMY
PR: themesberg/flowbite-angular#88
File: libs/flowbite-angular/navbar/navbar.component.ts:99-99
Timestamp: 2024-12-11T09:25:50.819Z
Learning: In `libs/flowbite-angular/navbar/navbar.component.ts`, the `NavbarContentComponent` was already required because the `verify` function threw an error if `navbarContentChild` was undefined or null. Therefore, changing `contentChild` to `contentChild.required` does not introduce a breaking change.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#110
File: apps/docs/docs/components/navbar/directive/_responsive.component.html:4-8
Timestamp: 2025-01-22T14:58:55.257Z
Learning: The `flowbite-navbar-toggle` directive in flowbite-angular:
1. Automatically includes a hamburger menu icon through its internal `flowbite-icon` component
2. Uses a theme-compatible SVG icon that adapts to the current color scheme using `currentColor`
3. Can be used both as a standalone element (`<flowbite-navbar-toggle>`) and as a directive on button elements (`<button flowbite-navbar-toggle>`)
4. Internally handles the click event to toggle the navbar's visibility
Learnt from: MGREMY
PR: themesberg/flowbite-angular#111
File: apps/docs/docs/components/sidebar/directive/_multi-level.component.html:0-0
Timestamp: 2025-01-23T16:05:19.849Z
Learning: The SidebarComponent in flowbite-angular internally generates the `<ul>` element to wrap sidebar items. When using `<aside>` for a sidebar, adding `<nav>` is redundant as `<aside>` already provides appropriate semantic context.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#96
File: libs/flowbite-angular/scroll-top/scroll-top.component.ts:70-76
Timestamp: 2024-12-16T13:51:08.299Z
Learning: In `libs/flowbite-angular/scroll-top/scroll-top.component.ts`, when using signals in the template and checking `@if (icon())`, it's safe to use `icon()!` within the block because `icon()` is guaranteed to be defined in this context.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#97
File: libs/flowbite-angular/accordion/accordion-title.component.ts:54-61
Timestamp: 2024-12-16T14:42:15.990Z
Learning: In the Flowbite Angular codebase, different components may have varying animation durations according to their design needs. For example, `duration-300` in `accordion-title.component.ts`, `duration-200` in `sidebar-item-group.component.ts`, and `duration-75` in `button.theme.ts` are intentionally set and acceptable.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#110
File: apps/docs/docs/components/navbar/directive/_dropdown.component.html:6-8
Timestamp: 2025-01-22T14:59:03.619Z
Learning: The `flowbite-navbar-content` component in flowbite-angular automatically creates a `<ul>` element internally, so `<li>` elements can be directly placed within it without an additional wrapping `<ul>`.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#110
File: apps/docs/docs/components/navbar/directive/_responsive.component.html:10-14
Timestamp: 2025-01-22T14:56:33.543Z
Learning: The `flowbite-navbar-content` component in flowbite-angular uses `<ul>` as its root element, so `<li>` elements can be placed directly inside it without an additional wrapping `<ul>` element.
Learnt from: MGREMY
PR: themesberg/flowbite-angular#108
File: libs/flowbite-angular/badge/badge.theme.ts:19-22
Timestamp: 2025-01-07T20:25:20.823Z
Learning: In Flowbite Angular, interfaces like `BadgeColors` that extend color types (e.g., `FlowbiteStandardColors`) intentionally include an index signature `[key: string]` to allow users to define their own custom color keys in the configuration.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build code 🛠 (20)
🔇 Additional comments (1)
libs/flowbite-angular/tab/src/tab-list/theme.ts (1)

17-17: Scrollbar behaviour fixed – looks good
Switching overflow-x-scroll to overflow-x-auto resolves the always-visible scrollbar without affecting scrollability. No further concerns.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MGREMY MGREMY merged commit 1f38755 into main Jul 20, 2025
9 checks passed
@MGREMY MGREMY deleted the fix/tab_overflow_always_displayed branch July 20, 2025 23:57
MGREMY added a commit that referenced this pull request Jul 20, 2025
* ci: rebase main after release (#129)

* fix(tab): fix tab overflow always displayed (#131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants