Skip to content

Conversation

@MGREMY
Copy link
Collaborator

@MGREMY MGREMY commented Jul 4, 2025

PR Type

What kind of change does this PR introduce?

  • Release

bence444 and others added 30 commits December 11, 2024 22:24
…ular into pagination

# Conflicts:
#	libs/flowbite-angular/core/flowbite.theme.init.ts
#	libs/flowbite-angular/pagination/index.ts
#	libs/flowbite-angular/pagination/pagination.component.ts
#	libs/flowbite-angular/pagination/pagination.theme.service.ts
#	libs/flowbite-angular/pagination/pagination.theme.ts
use `@angular/core/rxjs-interop` instead
# Conflicts:
#	libs/flowbite-angular/core/flowbite.theme.init.ts
#	libs/flowbite-angular/pagination/index.ts
#	libs/flowbite-angular/pagination/pagination.component.ts
#	libs/flowbite-angular/pagination/pagination.theme.service.ts
#	libs/flowbite-angular/pagination/pagination.theme.ts
…ular into pagination

# Conflicts:
#	libs/flowbite-angular/core/flowbite.theme.init.ts
## PR Checklist

Please check if your PR fulfills the following requirements:

<!--- [ ] Tests for the changes have been added (for bug
fixes/features)-->

- [ ] Docs have been added/updated (for bug fixes/features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [x] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] CI-related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## Issue Number

<!-- Bugs and features must be linked to an issue. -->

Issue Number: saw this in backlog:
https://github.com/orgs/themesberg/projects/11?pane=issue&itemId=88383003

## Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

- [ ] Yes
- [x] No

## Other information

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Streamlined lifecycle management in the ModalComponent, simplifying
the component's structure and functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
feat(pagination): remove directive & use flowbite-button
bence444 and others added 11 commits December 30, 2024 21:03
refactor(pagination): update post update post comment
## PR Checklist

Please check if your PR fulfills the following requirements:

<!--- [ ] Tests for the changes have been added (for bug
fixes/features)-->

- [x] Docs have been added/updated (for bug fixes/features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] CI-related changes
- [x] Documentation content changes
- [ ] Other... Please describe:

## Issue Number

<!-- Bugs and features must be linked to an issue. -->

Issue Number: N/A

## Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

- [ ] Yes
- [x] No

## Other information

Remaining works to do:
- [x] fix icons in first/last and prev/next button
- [x] possibility to use custom icons, like in accordion
(#95)
- [ ] ~~possibility to customize buttons' label + internalization~~
- [x] implement different size variables
- [x] remove duplications from
`libs/flowbite-angular/core/flowbite.theme.init.ts`
- [x] remove unused pageChange output
- [x] create InjectionTokens for properties (tabs, pageSize, etc..)
- [x] use a cleaner way to customize `PaginationButtonDirective` (big
thanks @MGREMY )
- [x] requested changes

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

## Release Notes: Flowbite Angular Pagination Component

- **New Features**
- Introduced multiple Pagination components with various configurations,
including default, custom, and text navigation modes.
- Added support for customizable pagination styles and attributes such
as current page, total items, and page size.
- Expanded the available SVG icons for navigation.

- **Documentation**
- Updated documentation with comprehensive examples for different
pagination styles and configurations.
- Added compatibility information for library versions with Angular and
TailwindCSS.

- **Improvements**
  - Enhanced theming capabilities for pagination components.
  - Improved error handling for page navigation controls.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* feat: make flowbite-button usable as directive

* docs: fix flex-wrap class

* docs: fix deprecated in button page

* feat: make flowbite-navbar-* usable as directive

* docs: add sidebar directive

* feat(sidebar): make flowbite-sidebar-* usable as directive

* docs(sidebar): fix z-40

* feat(accordion): make flowbite-accordion usable as directive

* feat(breadcrumb): make flowbite-breadcrumb usable as directive

* chore: add angular-primitive dependency

* refacto(button): migrate to angular-primitive (WIP)

* refacto(button): migrate to angular-primitive (WIP)

* refactor: add storybook for library

* refactor: button storybook add customStyle

* docs: add disabled to button storybook

* refactor: rename .css file

* refactor: lock file

* chore: add class import sort prettier plugin

* feat: switch to tailwindcss v4

* chore: add storybook to project

* chore: add dark mode in storybook

* refactor: path for 2.0.0 during dev phase

* feat: add injection of base theme for components

* refactor: rename root to host in theme

* refactor(button): add state

* refactor: remove v1 files

* refactor(button): outline (WIP)

* refactor: dependencies (WIP)

* refactor: dependencies (WIP)

* refactor: dependencies (WIP)

* refactor(button): adapt outline style

* refactor: dependencies (WIP)

* refactor(button): add styles

* refactor: move to css tailwind config

* refactor: clean config files

* refactor(accordion): migrate to v2

* refactor: fix token state creation

* refactor: change setting injection in components

* refactor: add exportAs for components

* refactor(alert): migrate to v2

* refactor(badge): migrate to v2

* refactor(breadcrumb): migrate to v2

* refactor(dropdown): migrate to v2

* refactor: add component generation tool

* refactor: add secondary entry point to generator

* refactor: move generator location

* refactor: catch error create entrypoint

* refactor: add host class

* refactor(indicator): migrate to v2

* refactor: add storybook generator

* refactor(modal): migrate to v2

* chore: pnpm-lock.json

* refactor: tailwindcss vscode settings

* chore: remove vercel config

* chore: update config for vercel deployments on v2

* chore: update config for vercel deployments on v2

* chore: update ng-primitive version

* refactor(icon): migrate to v2

* refactor(button): make abstract and create icon button

* refactor(button): make abstract and create icon button

* refactor(button): make styling abstract

* refactor(indicator): add colors

* refactor(): change modal button

* refactor(navbar): migrate to v2 (WIP)

* refactor(navbar): migrate to v2 (WIP)

* refactor(navbar): migrate to v2

* refactor: remove tests & tests libraries

* refactor: update ssr dependency

* refactor: add skeleton for v2

* refactor: make state internal

* refactor(sidebar): migrate to v2

* refactor(sidebar): migrate to v2

* refactor(theme-toggle): migrate to v2

* refactor(pagination): migrate to v2

* feat(tooltip): add new component #94

* feat(button-group): add new component

* feat(form-field): add new component

* feat(clipboard): add new component #92

* feat(card): add new component #91

* docs: to 2.0

* chore: update ng-primitives & ng-doc version

* docs: to 2.0

* chore: add documentation generator

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor(dropdown): to 2.0

* refactor(icon): to 2.0

* refactor(indicator): to 2.0

* refactor(navbar): to 2.0

* refactor(pagination): to 2.0

* refactor(sidebar): to 2.0

* refactor(sidebar): to 2.0

* refactor(tab): to 2.0

* refactor(tooltip): to 2.0

* refactor: tailwindcss dependencies

* refactor: ng-primitives dependencies

* chore: update to angular 20

* refactor: storybook dependencies

* refactor: pnpm-lock

* refactor: dependencies

* ci: simplify pnpm setup

* ci: re-setup

* ci: fix version

* docs: to 2.0

* ci: remove test ci

* chore: re-enable prerender

* fix: sidebar & navbar

* docs: fix display for some components

* docs(tab): create documentation

* chore: update ng-primitives

* docs: fix pagination behavior

* docs: fix sidebar toggle disapear

* docs: fix badge icons

* docs: fix global text color

* docs: update README

* docs: update README

* docs: update README

* docs: add page for ng-primitives

* docs: changes
@vercel
Copy link

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-angular ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 4:26pm
flowbite-angular-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 4:26pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MGREMY MGREMY merged commit 6bdd338 into release Jul 4, 2025
7 checks passed
MGREMY added a commit that referenced this pull request Jul 15, 2025
* feat(pagination): implement basics based on flowbite (wip)

* feat(pagination): implement basics based on flowbite (wip)

* feat(pagination): move button design to its own directive

* fix(modal): remove `rxjs` dependency

use `@angular/core/rxjs-interop` instead

* feat(pagination): implement basics based on flowbite (wip)

* feat(pagination): move button design to its own directive

* feat(pagination): implement basics based on flowbite (wip)

* fix: merge conflict

* feat(pagination): add icons, style active button, jsdoc comments

* docs(pagination): add NgDoc documentation

* fix(pagination): remove duplicated provider registrations

* fix(pagination): remove unused pageChange output

* fix(pagination): fix demo component selector

* chore: update modal function signature

* fix(pagination): correct first visible page

* feat(utils): add double chevron icon from `https://flowbite.com/icons/`

* feat(paginator): add customizable icons, size variables

* feat(pagination): add property providers

* feat(pagination): remove directive & use flowbite-button

* docs(lists): remove css & fix lists in md files

* chore(pagination): code style updates

* chore(pagination): use `model` instead of `input`

* refactor(pagination): remove `nav` element, use root and rootClass

* chore(pagination): code style

* feat(utils): add left/double left chevron icon

* feat(pagination): use left sided icons instead of `rotate-180`

* fix(pagination): place label before icon in next/last button

* refactor(pagination): update post update post comment

* refactor(pagination): fix doc attribute

* feat(pagination): possibility to use `totalPages` or  `totalItems`

* refactor(pagination): use `Array.from` instead of for loop

* chore: fix vercel deploy servless function compiled to commonJS

* feat: 2.0 (#115)

* feat: make flowbite-button usable as directive

* docs: fix flex-wrap class

* docs: fix deprecated in button page

* feat: make flowbite-navbar-* usable as directive

* docs: add sidebar directive

* feat(sidebar): make flowbite-sidebar-* usable as directive

* docs(sidebar): fix z-40

* feat(accordion): make flowbite-accordion usable as directive

* feat(breadcrumb): make flowbite-breadcrumb usable as directive

* chore: add angular-primitive dependency

* refacto(button): migrate to angular-primitive (WIP)

* refacto(button): migrate to angular-primitive (WIP)

* refactor: add storybook for library

* refactor: button storybook add customStyle

* docs: add disabled to button storybook

* refactor: rename .css file

* refactor: lock file

* chore: add class import sort prettier plugin

* feat: switch to tailwindcss v4

* chore: add storybook to project

* chore: add dark mode in storybook

* refactor: path for 2.0.0 during dev phase

* feat: add injection of base theme for components

* refactor: rename root to host in theme

* refactor(button): add state

* refactor: remove v1 files

* refactor(button): outline (WIP)

* refactor: dependencies (WIP)

* refactor: dependencies (WIP)

* refactor: dependencies (WIP)

* refactor(button): adapt outline style

* refactor: dependencies (WIP)

* refactor(button): add styles

* refactor: move to css tailwind config

* refactor: clean config files

* refactor(accordion): migrate to v2

* refactor: fix token state creation

* refactor: change setting injection in components

* refactor: add exportAs for components

* refactor(alert): migrate to v2

* refactor(badge): migrate to v2

* refactor(breadcrumb): migrate to v2

* refactor(dropdown): migrate to v2

* refactor: add component generation tool

* refactor: add secondary entry point to generator

* refactor: move generator location

* refactor: catch error create entrypoint

* refactor: add host class

* refactor(indicator): migrate to v2

* refactor: add storybook generator

* refactor(modal): migrate to v2

* chore: pnpm-lock.json

* refactor: tailwindcss vscode settings

* chore: remove vercel config

* chore: update config for vercel deployments on v2

* chore: update config for vercel deployments on v2

* chore: update ng-primitive version

* refactor(icon): migrate to v2

* refactor(button): make abstract and create icon button

* refactor(button): make abstract and create icon button

* refactor(button): make styling abstract

* refactor(indicator): add colors

* refactor(): change modal button

* refactor(navbar): migrate to v2 (WIP)

* refactor(navbar): migrate to v2 (WIP)

* refactor(navbar): migrate to v2

* refactor: remove tests & tests libraries

* refactor: update ssr dependency

* refactor: add skeleton for v2

* refactor: make state internal

* refactor(sidebar): migrate to v2

* refactor(sidebar): migrate to v2

* refactor(theme-toggle): migrate to v2

* refactor(pagination): migrate to v2

* feat(tooltip): add new component #94

* feat(button-group): add new component

* feat(form-field): add new component

* feat(clipboard): add new component #92

* feat(card): add new component #91

* docs: to 2.0

* chore: update ng-primitives & ng-doc version

* docs: to 2.0

* chore: add documentation generator

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* docs: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor: to 2.0

* refactor(dropdown): to 2.0

* refactor(icon): to 2.0

* refactor(indicator): to 2.0

* refactor(navbar): to 2.0

* refactor(pagination): to 2.0

* refactor(sidebar): to 2.0

* refactor(sidebar): to 2.0

* refactor(tab): to 2.0

* refactor(tooltip): to 2.0

* refactor: tailwindcss dependencies

* refactor: ng-primitives dependencies

* chore: update to angular 20

* refactor: storybook dependencies

* refactor: pnpm-lock

* refactor: dependencies

* ci: simplify pnpm setup

* ci: re-setup

* ci: fix version

* docs: to 2.0

* ci: remove test ci

* chore: re-enable prerender

* fix: sidebar & navbar

* docs: fix display for some components

* docs(tab): create documentation

* chore: update ng-primitives

* docs: fix pagination behavior

* docs: fix sidebar toggle disapear

* docs: fix badge icons

* docs: fix global text color

* docs: update README

* docs: update README

* docs: update README

* docs: add page for ng-primitives

* docs: changes

* chore: remove CHANGELOG file

---------

Co-authored-by: Bence Lovász <lovasz.b99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants