Skip to content

Conversation

@Xsear
Copy link
Contributor

@Xsear Xsear commented Jun 6, 2024

Mostly naming message handlers.
Tidbits around prng, combat log, parsing and chunk stuff.

@ThiconZ
Copy link
Member

ThiconZ commented Feb 5, 2025

Reviewing the deduplication import of this PR vs latest Main, there's a few items that will need to be resolved before this can be merged in.
image
Deduplication check performed via Name Manager > Import Names feature

  • slBuffer::sub_16CC8B0 being renamed to slBuffer_alloc looks fine (might want to change the _ into :: so decompiler tools like IDA can decide how to adjust the formatting on their own when dealing with function calls)
  • A number of items are renamed in slSerialize_unpacker_* categories. If the renames appear accurate, we can accept them.
  • If the renames are accepted, the right side conflict of Read_MovementPoseDebugData_1 will no longer be a conflict.

@Xsear
Copy link
Contributor Author

Xsear commented Feb 7, 2025

Updated the buffer func to use ::. Generally I avoid this in Ghidra due to some frustrations, but it is probably a bad habit.
All entries shown in the de-duplication image above are intentional renames that should improve the clarity (the _1 is meh but the improvement is the rename to _All on the other address).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants