Skip to content

Add feature remove index.php in the url and auto redirect http -> https#34

Draft
LucasCRENAIS wants to merge 4 commits into
thelia-modules:masterfrom
LucasCRENAIS:feat/autoindex.php
Draft

Add feature remove index.php in the url and auto redirect http -> https#34
LucasCRENAIS wants to merge 4 commits into
thelia-modules:masterfrom
LucasCRENAIS:feat/autoindex.php

Conversation

@LucasCRENAIS
Copy link
Copy Markdown

No description provided.

@gillesbourgeat gillesbourgeat marked this pull request as draft May 31, 2021 15:29
Comment thread Config/config.xml Outdated
Comment thread Config/config.xml Outdated
Comment thread Controller/Admin/ModuleConfigController.php Outdated
Comment thread Controller/Admin/ModuleConfigController.php Outdated
Comment thread Controller/Admin/ModuleConfigController.php Outdated
Comment thread EventListeners/RequestListener.php Outdated
Comment thread EventListeners/RequestListener.php Outdated
Comment thread EventListeners/RequestListener.php Outdated
Comment thread Controller/Admin/ModuleConfigController.php Outdated
Comment thread Config/config.xml Outdated
Comment thread EventListeners/RequestListener.php Outdated
Comment thread EventListeners/RequestListener.php Outdated
Comment thread templates/backOffice/default/RewriteUrl/module-configuration.html Outdated
@gillesbourgeat gillesbourgeat changed the title autoindex.php Addition of the feature remove index.php in the url and auto redirect http -> https Jun 7, 2021
@gillesbourgeat gillesbourgeat changed the title Addition of the feature remove index.php in the url and auto redirect http -> https Add feature remove index.php in the url and auto redirect http -> https Jun 7, 2021
Comment thread Config/routing.xml
Comment on lines +16 to +28

<!-- INDEX-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-index-redirection_enable" path="/admin/module/RewriteUrl/config/setIndexRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setIndexRedirectionEnableAction</default>
</route>
<!-- ############################# -->

<!-- HTTPS-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-https-redirection_enable" path="/admin/module/RewriteUrl/config/setHttpsRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setHttpsRedirectionEnableAction</default>
</route>
<!-- ############################# -->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- INDEX-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-index-redirection_enable" path="/admin/module/RewriteUrl/config/setIndexRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setIndexRedirectionEnableAction</default>
</route>
<!-- ############################# -->
<!-- HTTPS-REDIRECTION-ENABLE ROUTE -->
<route id="rewrite.url.config.set-https-redirection_enable" path="/admin/module/RewriteUrl/config/setHttpsRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setHttpsRedirectionEnableAction</default>
</route>
<!-- ############################# -->
<route id="rewrite.url.config.set-index-redirection_enable" path="/admin/module/RewriteUrl/config/setIndexRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setIndexRedirectionEnableAction</default>
</route>
<route id="rewrite.url.config.set-https-redirection_enable" path="/admin/module/RewriteUrl/config/setHttpsRedirectionEnable">
<default key="_controller">RewriteUrl\Controller\Admin\ModuleConfigController::setHttpsRedirectionEnableAction</default>
</route>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants