Skip to content

Conversation

@zskullz
Copy link

@zskullz zskullz commented Nov 10, 2019

Use animation functions instead of copy paste for each zone and section

Use animation functions instead of copy paste for each zone and section
@zskullz
Copy link
Author

zskullz commented Nov 10, 2019

This will make the code much easier to maintain for a few reason. If a change, fix or customization is needed for an animation, it can be done in one place; If a new animation is added, the function doesn't need to be duplicated for every zone/section; It will require less code to add additional zones/sections.

Fix missed reference changes
@zskullz
Copy link
Author

zskullz commented Nov 14, 2019

Great example of how copy-paste can go wrong :)

add fireworks - WIP
@zskullz zskullz requested a review from thehookup February 5, 2020 04:25
@gniknalu
Copy link

My Set-up uses three zones. Fireworks is awesome! Heartbeat is cool! Can't seem to get "Ripple" to work. It is just a solid fill. (Maybe there is a config change that wasn't obvious that I missed for HA and/or MQTT?)

@zskullz
Copy link
Author

zskullz commented Sep 26, 2020

My Set-up uses three zones. Fireworks is awesome! Heartbeat is cool! Can't seem to get "Ripple" to work. It is just a solid fill. (Maybe there is a config change that wasn't obvious that I missed for HA and/or MQTT?)

Ripple is something I believe TheHookup was working on, i haven't figured out what it is suppose to do or gotten it to work yet. I did just add some major changes though and would love your feedback on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants