-
Notifications
You must be signed in to change notification settings - Fork 34
Optimize code #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Optimize code #19
Conversation
Use animation functions instead of copy paste for each zone and section
|
This will make the code much easier to maintain for a few reason. If a change, fix or customization is needed for an animation, it can be done in one place; If a new animation is added, the function doesn't need to be duplicated for every zone/section; It will require less code to add additional zones/sections. |
Fix missed reference changes
|
Great example of how copy-paste can go wrong :) |
add fireworks - WIP
Add valentine animation
|
My Set-up uses three zones. Fireworks is awesome! Heartbeat is cool! Can't seem to get "Ripple" to work. It is just a solid fill. (Maybe there is a config change that wasn't obvious that I missed for HA and/or MQTT?) |
Update mqtt status topics on reconnect New traditional solid lights
Ripple is something I believe TheHookup was working on, i haven't figured out what it is suppose to do or gotten it to work yet. I did just add some major changes though and would love your feedback on them. |
Use animation functions instead of copy paste for each zone and section