Conversation
Member
|
This is looking very good. 👍 However … what is going to happen on Monday morning when the feed is updated and how might we solve that problem? |
Collaborator
Author
|
Ah yes very good point. My initial thinking is:
But will need to see what happens if the fetch fails (because someone is offline). |
Member
|
Nice thought. A step before that: Wait until initial load completed - don't slow everything down for this. Just assume everything is fine on first load ( A step after that: Update the state if local storage changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WOOP
Seems to be working, although haven't been able to test how it would work being offline in chrome.
Seen below is screenshot of localstorage in chrome.

Probably not following pull request etiquette here...