Skip to content

Support ESLint v10 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azat-io wants to merge 1 commit into
base: v3
Choose a base branch
from
+2,139 −3,396
Open

Support ESLint v10 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/eslint-v10-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-prefer-let": minor
---

Support ESLint v10
2 changes: 1 addition & 1 deletion packages/eslint-plugin-prefer-let/lib/rules/prefer-let.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
},

create: function(context) {
let sourceCode = context.getSourceCode();
let sourceCode = context.sourceCode ?? context.getSourceCode();

//----------------------------------------------------------------------
// Helpers
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-prefer-let/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"devDependencies": {
"@typescript-eslint/parser": "^8.0.0",
"eslint": "^9.3.0",
"eslint": "^10.0.0",
"globals": "^15.3.0",
"mocha": "^9.1.3"
},
Expand Down
18 changes: 6 additions & 12 deletions packages/eslint-plugin-prefer-let/tests/lib/rules/prefer-let.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,37 +72,32 @@ ruleTester.run("prefer-let", rule, {
code: "function y() { const x = 'y'; return x; }",
output: "function y() { let x = 'y'; return x; }",
errors: [{
message: "`const` declaration outside top-level scope",
type: "VariableDeclaration"
message: "`const` declaration outside top-level scope"
}]
},
{
code: "function y() { const {x, y} = {x: 'x', y: 'y'}}",
output: "function y() { let {x, y} = {x: 'x', y: 'y'}}",
errors: [{
message: "`const` declaration outside top-level scope",
type: "VariableDeclaration"
message: "`const` declaration outside top-level scope"
}]
},
{
code: "var x = 'y';",
errors: [{
message: "prefer `let` over `var` to declare value bindings",
type: "VariableDeclaration"
message: "prefer `let` over `var` to declare value bindings"
}]
},
{
code: "function y() { var x = 'y'};",
errors: [{
message: "prefer `let` over `var` to declare value bindings",
type: "VariableDeclaration"
message: "prefer `let` over `var` to declare value bindings"
}]
},
{
code: "function y() { var { x, y } = {}; }",
errors: [{
message: "prefer `let` over `var` to declare value bindings",
type: "VariableDeclaration"
message: "prefer `let` over `var` to declare value bindings"
}]
},
{
Expand All @@ -115,8 +110,7 @@ ruleTester.run("prefer-let", rule, {
code: "function y() { const x = 'y'; return x; }",
output: "function y() { let x = 'y'; return x; }",
errors: [{
message: "`const` declaration outside top-level scope",
type: "VariableDeclaration"
message: "`const` declaration outside top-level scope"
}]
},
]
Expand Down
Loading
Loading