Skip to content

Fix flaky converge timing tests on CI#203

Open
taras wants to merge 1 commit intomainfrom
fix/flaky-converge-test
Open

Fix flaky converge timing tests on CI#203
taras wants to merge 1 commit intomainfrom
fix/flaky-converge-test

Conversation

@taras
Copy link
Copy Markdown
Member

@taras taras commented Mar 27, 2026

Summary

  • Widen timestamp tolerance from 5ms to 50ms in the "resolves with a stats object" tests for both when and always
  • The 5ms window between the test's Date.now() and convergeOn's internal Date.now() was too tight — effection scheduling overhead can exceed 5ms on slow macOS CI runners

Test plan

  • All 17 converge tests pass locally
  • CI passes on all platforms (the fix specifically targets the intermittent macOS failure)

Widen timestamp tolerance from 5ms to 50ms in "resolves with a stats
object" tests for both `when` and `always`. The 5ms window was too
tight for slow CI runners where effection scheduling overhead between
the test's Date.now() and the internal Date.now() can exceed 5ms.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Warning

Rate limit exceeded

@taras has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 42 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 20 minutes and 42 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bb520957-56e1-4140-beef-dca81c4defa5

📥 Commits

Reviewing files that changed from the base of the PR and between cdf75f3 and 4075d47.

📒 Files selected for processing (1)
  • converge/converge.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/flaky-converge-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 27, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@effectionx/converge@203

commit: 4075d47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant