Open
Conversation
Since effectionx only uses Node/PNPM, remove the unused Deno package implementation to simplify the codebase. Changes: - Delete lib/package/deno.ts (Deno package implementation) - Update lib/package/mod.ts to only export Node package - Simplify lib/workspaces/mod.ts to only support PNPM monorepos - Update use-deno-doc.tsx to import DenoJsonSchema from lib/deno-json.ts
commit: |
cowboyd
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since effectionx only uses Node/PNPM, the Deno package implementation is dead code that adds unnecessary complexity.
Approach
lib/package/deno.ts(Deno package implementation)lib/package/mod.tsto only export Node packagelib/workspaces/mod.tsto only support PNPM monorepos (removed Deno workspace detection)use-deno-doc.tsxto importDenoJsonSchemafromlib/deno-json.ts(which is still needed for doc generation)