Skip to content

Finished the project#266

Open
Sephydev wants to merge 2 commits intothe-csharp-academy:mainfrom
Sephydev:main
Open

Finished the project#266
Sephydev wants to merge 2 commits intothe-csharp-academy:mainfrom
Sephydev:main

Conversation

@Sephydev
Copy link
Copy Markdown

@Sephydev Sephydev commented May 5, 2026

Hi, thank you for the review!
Like earlier project, I didn't do the AI Challenge. I didn't do the Desktop app challenge too, because I want to see MAUI at the right moment.
Really fun project, I think I will use the Coding Tracker when I'm coding now!

Copy link
Copy Markdown

@DSills735 DSills735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Sephydev I am here to review your code. Thank you for taking the time to do this project! Please ignore/review my comments as you wish. I will add a list here, and add screenshots and further details in the comments of the PR if necessary.

Anything marked with a "🔴" blocks approval, and is the bare minimum of what must be fixed to be approved. Withour further ado, here is my review:

Good things

  • CRUD Operations work as expected.
  • All 44 unit tests pass!
  • You have passed all of the base requirements, sorting is correct.
  • Validation is excellent. Edge cases are adequately handled.

Improvements

  • UI/UX is really frustrating to navigate. What if I mistakenly click a menu and want to go back?
  • When filtering by day or week, the user is requested to enter day number or week number. Im sure there is a better way to do this.
  • 🔴 A day number entry, will return any day # of a month it was input, not necessarily an individual day.
  • 🔴 If a study session spans past midnight, it will not return from a single day search. Ex. May 5 start time, May 6 end time will not return from day # 5 or 6.

Please fix these issues, and @ me when you are ready for another review. Thank you!

I will note, as both of the areas that block approval are part of the challenges, this are of the project can either be removed or corrected. Both would satisfy requirements and allow me to approve this project.

@DSills735

@DSills735
Copy link
Copy Markdown

DSills735 commented May 6, 2026

Multiple days shown on request for individual day sorting (my input was day 3):

multiple days shown

@DSills735
Copy link
Copy Markdown

DSills735 commented May 6, 2026

No option to leave this menu after I mistakenly clicked into it. The menus leading up to this will not allow me to return to main either. This issue is project wide.

can leave update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants