feat: add article parsing and handling to timeline and scraper modules#195
Open
fibonacci998 wants to merge 2 commits into
Open
feat: add article parsing and handling to timeline and scraper modules#195fibonacci998 wants to merge 2 commits into
fibonacci998 wants to merge 2 commits into
Conversation
fibonacci998
commented
May 25, 2026
fibonacci998
commented
- feat: add article parsing and handling to timeline and scraper modules
- test: add article parsing coverage to tweets.test.ts
Ports the article-extraction work from PR the-convocation#146 (LiamVDB1) onto current main. The previous PR drifted behind main since 2025-07-11 and never got its requested tests; this commit applies the same diff cleanly and follow-up commits add the tests + drop the unrelated `prepare` script change that broke CI for downstream consumers. Adds support for X "Articles" (long-form posts) inside the timeline data structure: * `ArticleRaw`, `ArticleResultRaw`, `ArticleContentStateRaw` interfaces in src/timeline-v1.ts representing the raw article payload, including metadata, media, and content state. * `parseArticleToMarkdown` and `parseArticle` in src/timeline-v2.ts that walk `content_state.blocks` and produce markdown (handling text, links, bold/italic, headers, lists, and inline media). * `parseResult` now detects `result.article.article_results.result` and, when present, sets `tweet.isArticle = true`, populates `tweet.article`, and overwrites `tweet.text` with the rendered markdown (since `legacy.full_text` for an Article tweet is just the t.co URL stub). * `Tweet` interface gains optional `isArticle` and `article` fields. Co-authored-by: LiamVDB1 <liam.van.den.berge@hotmail.com>
Addresses karashiiro's review request on PR the-convocation#146. Two tests against the public article tweet 2053808119709659225 (subnetamplify): * isArticle flag is set, article.id matches the article rest_id (not the tweet id — they are distinct), and content_state is populated. * tweet.text is replaced with the rendered markdown body, far larger than the t.co URL stub and starting with an H1 of the article title. Co-authored-by: LiamVDB1 <liam.van.den.berge@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.