Conversation
|
Hi @klamike , Could you ping some authors for reviews ? This benchmark does a warmup phase, I have to change the documentation to reflect that. Regards, |
Co-authored-by: Marwan Rabbâa <waghanza@gmail.com>
Co-authored-by: Marwan Rabbâa <waghanza@gmail.com>
Is this necessary? The code is MIT, I'm confident the usage is correct since it is so simple, and I'm happy to maintain this code myself if you want to expand the benchmark in the future. Just looking out for their time. I think most of the contributors to HTTP.jl are involved in lots of packages, there is no "dedicated maintainer" AFAIK. |
|
I'm sure of it @klamike , and glad you which to maintain HTTP.jl implementation here. The idea is just to notify any author to pay respect, and let them the chance to "say no". It occurs a few times that authors have been opposd to include it here. I do not understand this kind of decision, but I pledge to respect it for this benchmark. I hope you understand. |
|
@BioTurboNick @quinnj we plan to introduce HTTP.jl here. Despote the MIT licence, I which to pong some authors to see if this is accurate ... And of course if this is OK for you, I mean if somebody do not want it to be include here, we won't |
|
If no explicit refusal, I'll merge before updating results @klamike |
|
I'm not an author of it, I just made a small PR recently. |
|
Yeah, fine by me. Note that we'll hopefully be merging/releasing the 2.0 release soon, which completely overhauls the internals to use the aws-c-http library under the hood (instead of the current mishmash of pure julia + openssl + libuv). |
4 participants
Adds JuliaWeb/HTTP.jl, based on #8482
This will grab the latest HTTP.jl with major version 1 and minor version greater than 10, though note work is under way for version 2 at JuliaWeb/HTTP.jl#1213. When that is merged the compat will need to be bumped.
Does the benchmark do any warmup requests? This is important to get good results in Julia since it is doing lazy compilation on the first requests.