-
Notifications
You must be signed in to change notification settings - Fork 0
Fix my branch #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tf-mac
wants to merge
32
commits into
factorization
Choose a base branch
from
main
base: factorization
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix my branch #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cs3110project.yaml
- Documented database.mli - Some functions are not properly documented
Updating my branch
Minor fixes to database.mli
- created the CLI for find expressions - used placeholder function on call
- added CLI test cases to 75% bisect coverage - created makefile to run CLI interface and test cases
Jt -> main
- changed TypeMismatch to be localized in the Util File - added test cases to CLI
- checked yaml - checked make test - checked make doc - checked make run - checked install instructions
- made sure make test runs - made sure that everything required exists - test methodology comment - module descriptions - made sure that make run works - made sure that make doc works - made sure installation instructions are correct - made sure yaml file is correct - made sure LOC >1200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.