Adding support for heredocs used in functions.#78
Open
waratuman wants to merge 3 commits intotextmate:masterfrom
Open
Adding support for heredocs used in functions.#78waratuman wants to merge 3 commits intotextmate:masterfrom
waratuman wants to merge 3 commits intotextmate:masterfrom
Conversation
Previously using a heredoc in a function would result in the rest of the
line after a heredoc assumed as being part of the string and would be
makred as part of the heredoc, but the heredoc doesn't start until the next
line.
eg. exec_sql(<<SQL, 1, 'book')
SELECT * FROM products WHERE id = ? OR name = ?;
SQL
This commit marks the heredoc declarations and the heredoc as part of
the heredoc, but leaves the rest of the line marked as ruby.
Also adding support heredocs with backticks.
Adding support for here docs that use the double chevrons '<<' in argument lists. eg. puts "hi", <<DOC hello world DOC
Author
|
Also addresses #73 |
* upstream/master: Use updated documentation command on 10.10 Add keyword `fail` to grammar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously using a heredoc in a function would result in the rest of the
line after a heredoc assumed as being part of the string and would be
makred as part of the heredoc, but the heredoc doesn't start until the next
line.
eg. exec_sql(<<SQL, 1, 'book')
SELECT * FROM products WHERE id = ? OR name = ?;
SQL
This commit marks the heredoc declarations and the heredoc as part of
the heredoc, but leaves the rest of the line marked as ruby.
Also adding support heredocs with backticks.