Use Native Ruby #20
Open
Use Native Ruby #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ruby20` was an old Homebrew-installed version for getting Ruby 2 on old macOS (see https://stackoverflow.com/a/14138490). This fix simply uses system installed Ruby, which ensures macOS compatibility on supported versions since 10.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby20was an old Homebrew-installed version for getting Ruby 2 on old macOS (see https://stackoverflow.com/a/14138490). This fix simply uses system installed Ruby, which ensures macOS compatibility on supported versions since 10.9For reference, this is one of many uses throughout the TM Bundle codebase, which guarantee that the affected Bundle Commands will not run on any version of vanilla macOS: https://github.com/search?q=org%3Atextmate+ruby20&type=Code
Before this change, attempting to run any affected Bundle Command results in an error: "Unable to Run Command: This command requires OS X 10.9 or higher." which appears to be caught by a compatibility check. Since TextMate now targets 10.9 or later, this compatibility check/error handler should be removed, but I am unable to locate in the codebase. See attached: