Replace various "Visualize with..." menu items with single configurable item#14
Open
mrabbitt wants to merge 2 commits intotextmate:masterfrom
Open
Replace various "Visualize with..." menu items with single configurable item#14mrabbitt wants to merge 2 commits intotextmate:masterfrom
mrabbitt wants to merge 2 commits intotextmate:masterfrom
Conversation
added 2 commits
September 9, 2013 23:42
… "External App" command.
…o feature/configurable_external_app # Conflicts: # Commands/Use Git-Gui.tmCommand # Commands/Use GitX.tmCommand # Commands/Use Gitnub.tmCommand
Author
|
In case someone else finds this useful, I've just merged recent changes from the base branch into my pull request branch. I've been using the changes in this pull request myself for over two years (mostly with SourceTree) without issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
As per discussion in Pull request 1, the Git bundle menu is quite long and has top-level commands to open the project in various GUI apps (GitX, gitk, etc.). I wanted to add similar support for SourceTree, but this would make the menu even longer and more unwieldy.
In this pull request:
Visualize History with ...items menu items have been removed and replaced with a singleVisualize History with External Git Appitem. (There's probably a better way to name this command...suggestions?)Visualize History with External Git Appis configured via the config dialog. The user can choose between several preset apps, or choose "custom" and add a custom shell command to be run instead.I've tested the changes with every listed app except for Gitnub.
The UI for the config dialog could be cleaned up a bit more: There are text fields for custom paths to GitX and Gitnub which are currently displayed no matter which app is selected from the menu. I'd like to add some Javascript to dynamically show/hide these fields based on the app selection, but before I go down that path, I wanted to get some feedback on this overall approach.
Let me know what you think of this approach. Thanks.