Open
Conversation
Fix RandomX fails to build as shared library on AArch64 due to non-PIC assembly symbol (ADR relocation error) tevador#321
Author
|
best idea change to: |
Fixed macOS build failure by conditionally excluding the .hidden directive in AArch64 assembly using #ifndef __APPLE__, ensuring compatibility with the Apple assembler while preserving Linux/windows behavior.
SChernykh
reviewed
Apr 8, 2026
Thanks @ SChernykh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RandomX fails to build as shared library on AArch64 due to non-PIC assembly symbol (ADR relocation error)
#321