refactor: remove pear-wrk-wdk dependency and pass bundleConfig directly #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatteo
force-pushed
the
refactor/remove-pear-wrk-wdk-dependency
branch
from
04446b1 to
412e770
Compare
3 tasks
Remove the tight coupling to pear-wrk-wdk by accepting bundleConfig (containing bundle and HRPC) as explicit function parameters instead of importing from the package directly. Key changes: - WorkletLifecycleService.startWorklet now accepts bundleConfig as 2nd param - WdkAppProvider passes bundleConfig directly to startWorklet - ensureWorkletStarted simplified to just validate worklet is started - Remove pear-wrk-wdk from dependencies - Update all tests to use local mocks instead of pear-wrk-wdk imports - Define HRPC types locally in src/types/hrpc.ts This allows consumers to provide their own bundle and HRPC implementation, making the library more flexible and decoupled.
- Add Bundle Configuration section explaining two options: - Option A: Generate custom bundle with wdk-worklet-bundler CLI - Option B: Use pre-built pear-wrk-wdk package - Update all examples to include the required bundle prop - Update WdkAppProvider API reference with full props interface - Add TypeScript configuration guidance for generated bundles
Set SecureStorage in WalletSetupService synchronously during render instead of in a useEffect. This prevents race conditions where child components' useEffect hooks run before the parent's effect, causing "SecureStorage not initialized" errors.
gatteo
force-pushed
the
refactor/remove-pear-wrk-wdk-dependency
branch
from
f470ed1 to
7607a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the tight coupling to pear-wrk-wdk by accepting bundleConfig (containing bundle and HRPC) as explicit function parameters instead of importing from the package directly.
The worklet is now started only in the provider.
Key changes:
This allows consumers to provide their own bundle and HRPC implementation, making the library more flexible and decoupled.