fix #572: TestNG view may miss results #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestNG view in Eclipse could be incomplete and show the wrong status if tests were executed faster than the UI updates. The reason was that the listener receiving the TestResultMessages updated the UI synchronously. Once the test finished the UI update would stop. Unprocessed test results were dropped. Fixed by queueing all synchronous UI updates and executing them in the order they arrived.
Collaborator
|
LGTM, thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestNG view in Eclipse could be incomplete and show the wrong status if tests were executed faster than the UI updates. The reason was that the listener receiving the TestResultMessages updated the UI
synchronously. Once the test finished the UI update would stop. Unprocessed test results were dropped.
Fixed by queueing all synchronous UI updates and executing them in the order they arrived.