fix(elasticsearch): Use wait strategy instead of deprecated decorator #915
+4
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexanderankin whenever you have time please take a look |
Contributor
Author
|
@alexanderankin kind reminder |
artem-ilin
force-pushed
the
elasticsearch-wait-strategy
branch
from
afd19bc to
3fe0eb8
Compare
artem-ilin
force-pushed
the
elasticsearch-wait-strategy
branch
from
3fe0eb8 to
2d39872
Compare
Contributor
Author
|
@alexanderankin please take a look |
alexanderankin
approved these changes
Dec 5, 2025
Member
|
lets see the tests pass on python 3.9 for the module and then merge |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 78.18% 77.93% -0.25%
==========================================
Files 14 14
Lines 1210 1210
Branches 187 187
==========================================
- Hits 946 943 -3
- Misses 222 226 +4
+ Partials 42 41 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@alexanderankin Huge thanks! Tests seem to pass. The codecov and docs/build jobs fail in the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing #874.
Decided to remove
get_urlmethod as it's no longer used and is not part of the protocol.