Skip to content

Enable CI for all major platforms and highlight the broken support for Windows#69

Open
nikita-volkov wants to merge 2 commits intotestcontainers:masterfrom
nikita-volkov:cover-all-platforms-in-ci
Open

Enable CI for all major platforms and highlight the broken support for Windows#69
nikita-volkov wants to merge 2 commits intotestcontainers:masterfrom
nikita-volkov:cover-all-platforms-in-ci

Conversation

@nikita-volkov
Copy link
Copy Markdown

@nikita-volkov nikita-volkov commented Mar 19, 2026

GitHub Actions now support running Docker on all major platforms. This PR enables them all and uncovers the preexisting issues on Windows (approve the workflow execution and see the run results).

The main reason is that the image of ryuk that the library uses (v0.3.4) is outdated and does not support Windows. The later releases of it do (e.g., v0.14.0).

However as I've already discovered trying to fix this myself, it is not only a matter of updating the image, other issues appear when it's done and I'm struggling to fix this myself since I have no experise in the library and I don't have a Windows machine.

Since GitHub Actions now support it
@alexbiehl
Copy link
Copy Markdown
Collaborator

Can we do anything about those failing tests or should we scrap them for now?

@nikita-volkov
Copy link
Copy Markdown
Author

I see two issues at hand here.

  1. The tests are flaky on macOS. It can be seen that one run on macOS passes fine while another fails with timeout exception:

    Exception: TimeoutException {id = "aa4fc0a7a91ea3966505cfc81ed5da1c633fe8a7a9cf679892554d65d5ff49cf", imageName = Just "docker.io/library/rabbitmq:3.8.4", containerName = Just "/eloquent_lichterman"}
    

    However the integration with macOS works fine, so the library does support it and that can be claimed in the docs.

    This issue can be addressed by simply fixing the tests.

  2. With the current integration with ryuk Windows is not supported. I would highlight that in the docs and register that as a feature request to provide support for it by updating the ryuk integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants