-
Notifications
You must be signed in to change notification settings - Fork 29
Fix Ryuk disabled #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ryuk disabled #234
Conversation
|
do you think its possible to make any kind of test that can verify if the conditional reaper process generation works? |
|
read your comment about base and v1 too late or didnt read it at all. You can force push over this. And about v2 and v1. We can backport later, when we have the update ready. I will make a branch from v1 at that time and cherry pick the commit over. and then release v1.14.1. |
|
Ill make a quick release today. Will cherrypick into a v1 branch. Test can be added in v2 |
|
added test here 6652b35 |
|
a pretty normal testrun now on main ;) |
|
i deleted v1 since its just making noise. If more backports are needed, new v1 branch must be created from the last tag |
|
Hooray, thank you so much 🧡 |
|
@gossi you can also try to use v2.0.0-rc for the same purpose. Its basically the same but without the ecto module, improved kafka, cassandra and redis container. |
It's a fix for ryuk disabled as described in #228
This PR uses this commit as a base: 8fbe1eb
That is, you can create a branch from the commit above:
v1.*and we can set this as target branch for this PR, which allows your changes to stay unaffected but be able to release a hotfix.In a second effort, this PR can be revived and applied onto the main branch, too.