Merged
Conversation
compaluca
approved these changes
Jun 2, 2023
Contributor
compaluca
left a comment
There was a problem hiding this comment.
thanks a lot @felix-20 ! Please add specific issues (if not done yet) for the patterns where problems are experienced:
- Exceptions - cpg generation fails: Pattern 19
- Exceptions - could profit from source code discovery (?): Pattern 5, 40, 55, 47, 48, 80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a review of all PHP patterns. All patterns were manually looked at, php code was executed and spelling mistakes corrected. Additionally, the tpframework was used to run
checkdiscoveryrules(to verify that the discovery rule works) andmeasure.The following things should now be uniform across all patterns now:
./docs/description.mdcheckdiscoveryrulessource->tarpit->sink(for some patterns, this is not possible, if so, it should be indicated byinjection_skeleton_broken: true)Patterns 6 (#36), 45 (#37), 47 (#35), 75 (#38) and 83 (#39) are not included in this PR, as they have larger changes. The PR including these patterns can be found #41