Added CycloneDX License ID Validation Capability For CycloneDX Formatted SBOMs#1250
Open
REestwick wants to merge 5 commits intotern-tools:mainfrom
Open
Added CycloneDX License ID Validation Capability For CycloneDX Formatted SBOMs#1250REestwick wants to merge 5 commits intotern-tools:mainfrom
REestwick wants to merge 5 commits intotern-tools:mainfrom
Conversation
Add License Processing Capability For CycloneDX Generated SBOMs
added license validation using the cyclonedx-python-lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating CycloneDX (JSON) SBOMs, license information is added in the form of a License ID, as following:
in file
tern/tern/formats/cyclonedx/cyclonedx_common.py.When this license information is not a valid SPDX license ID, as defined in the CycloneDX JSON Schema, it results in an invalid SBOM.
E.g. GPLv2+ (incorrect) as opposed to GPL-2.0+ (correct).
This proposed fix alters the
get_license_from_namefunction to validate the name input as a valid SPDX license ID, utilising the cyclonedx-python-lib python module.If this validation fails, the
get_license_from_namefunction returns the license as a CycloneDX License Name, which can be any string.