Conversation
Member
Author
|
/merge-queue |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_task_result()toDurable<State>for polling task status and retrieving output/error info after spawningTaskStatus,TaskPollResult,TaskErrorInfodurable.get_task_resultstored procedure (migration + schema.sql)InvalidStatevariant onDurableErrorNote
Medium Risk
Introduces new database function/migration and a new public client API that depends on DB state strings; mis-migrations or unexpected state values could break polling at runtime.
Overview
Adds a new polling surface via
Durable::get_task_result(task_id)that returnsNonefor unknown tasks and otherwise exposes task state plus either the completed output payload or structured error info for failed tasks.Implements this by adding a
durable.get_task_result(queue_name, task_id)Postgres function (migration +schema.sql) that reads from the queue’s task table and joins the latest attempt run forfailure_reason, plus new public types (TaskStatus,TaskPollResult,TaskErrorInfo) and a newDurableError::InvalidStatefor unexpected DB state strings. Includes end-to-end tests covering pending/completed/failed/cancelled/nonexistent cases and user-error round-tripping.Written by Cursor Bugbot for commit 2d6a9f6. This will update automatically on new commits. Configure here.