Skip to content

Conversation

@virajmehta
Copy link
Member

Fixes a bug: defaults on max_attempts were not being propagated to child tool spawns.
As part of the fix, I extended the API to allow callers to configure defaults for more than just max_attempts:

  let client = Durable::builder()
        .pool(pool.clone())
        .queue_name("fanout_by_name")
        .default_max_attempts(7)
        .default_retry_strategy(RetryStrategy::Exponential {
            base_delay: Duration::from_secs(10),
            factor: 3.0,
            max_backoff: Duration::from_secs(600),
        })
        .default_cancellation(CancellationPolicy {
            max_pending_time: Some(Duration::from_secs(3600)),
            max_running_time: None,
        })
        .build()
        .await
        .expect("Failed to create client");

These are now applied to all spawns and fully configurable.

@virajmehta virajmehta marked this pull request as ready for review January 2, 2026 01:45
@virajmehta
Copy link
Member Author

I am investigating this failure

@virajmehta virajmehta marked this pull request as draft January 2, 2026 02:16
@virajmehta virajmehta marked this pull request as ready for review January 2, 2026 02:20
@virajmehta
Copy link
Member Author

@codex review

@GabrielBianconi GabrielBianconi added this pull request to the merge queue Jan 2, 2026
@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Merged via the queue into main with commit ca986b6 Jan 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants