Skip to content

Fix warnings of c++ compilation#476

Open
jaeyoo wants to merge 11 commits intomasterfrom
fix_warnings
Open

Fix warnings of c++ compilation#476
jaeyoo wants to merge 11 commits intomasterfrom
fix_warnings

Conversation

@jaeyoo
Copy link
Copy Markdown
Member

@jaeyoo jaeyoo commented Feb 7, 2021

@jaeyoo
Copy link
Copy Markdown
Member Author

jaeyoo commented Feb 8, 2021

Please merge this one earlier than #477 if possible

@zaqqwerty
Copy link
Copy Markdown
Contributor

zaqqwerty commented Aug 25, 2021

Seems stale at this point, do you wish to update or should we close for now?

@jaeyoo
Copy link
Copy Markdown
Member Author

jaeyoo commented Aug 25, 2021

Seems stale at this point, do you wish to update or should we close for now?

Let me update it :)

@jaeyoo jaeyoo requested a review from zaqqwerty August 26, 2021 00:34
Copy link
Copy Markdown
Contributor

@zaqqwerty zaqqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, have a couple questions. If the resolution of the static function stuff is unclear we can merge the rest without touching util_qsim, this will just leave unused function warnings, which is a big improvement :)

Comment thread tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated
Comment thread tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated
Comment thread tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated
Comment thread tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated
Comment thread tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated
Comment thread tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated
Comment thread scripts/test_all.sh Outdated
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
@mhucka mhucka added the area/health Involves general matters of project configuration, health, maintenance, and similar concerns label Dec 2, 2024
@mhucka mhucka self-assigned this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/health Involves general matters of project configuration, health, maintenance, and similar concerns

Projects

Development

Successfully merging this pull request may close these issues.

3 participants