Skip to content

Fix metadata missing value handling in LAION-400M#11184

Open
tomvdw wants to merge 1 commit intomasterfrom
fix-laion400m-nan-11386619042776102784
Open

Fix metadata missing value handling in LAION-400M#11184
tomvdw wants to merge 1 commit intomasterfrom
fix-laion400m-nan-11386619042776102784

Conversation

@tomvdw
Copy link
Copy Markdown
Collaborator

@tomvdw tomvdw commented May 6, 2026

Fixes a failing test in tensorflow_datasets/vision_language/laion400m/laion400m_test.py caused by a TypeError when serializing NaN string values.


PR created automatically by Jules for task 11386619042776102784 started by @tomvdw

Missing values from Pandas were being extracted as `NaN` and evaluated as truthy, preventing them from being correctly replaced with an empty string and failing validation during serialization. Now checking with `pd.isna` instead to correctly extract empty strings or the designated missing value placeholder.

Co-authored-by: tomvdw <4160552+tomvdw@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant