-
Notifications
You must be signed in to change notification settings - Fork 0
Bringing this branch up-to-date #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tennitech
wants to merge
42
commits into
33-curved-slider
Choose a base branch
from
main
base: 33-curved-slider
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint (still not perfect)
Automatically add 2 "random" songs to the queue if the queue is empty
…ently-played-ctx
Co-authored-by: Evan Whymark <whymarkevan@gmail.com>
Co-authored-by: Evan Whymark <whymarkevan@gmail.com>
Player Buttons Bug Fix
…ently-played-ctx
Co-authored-by: Evan Whymark <whymarkevan@gmail.com>
Feat: Replace static Library footer PNG with dynamic album art gradient
Fix Fonts and Spacing
Update README.md
Removed Recently Played flickering
Added shuffle and loop icon assets
Updating branch with latest changes from main
Add recently played info to PlayerContext, autoplay when queue is empty, store recentlyPlayed locally
…-and-loop-buttons
Adds a ScrollableText component to handle overflowing text. - Scrolls back and forth only when text exceeds container width. - Calculates scroll distance dynamically to show end of text while keeping most visible. - Includes 3-second pauses at start and end of scroll. - Supports different animation speeds for title vs. artist. - Uses dynamic edge fading (mask-image) that transitions smoothly and persists during pauses. - Animation restarts when text changes and pauses on hover. - Responsive to window resizing.
Now says "Sign-In Required" replacing the previous "Unknown" text.
Add Shuffle and loop buttons
-Changed default track and artist placeholders to "Welcome to Juke" and "Your Music, Reimagined" respectively -Removed ScrollableText.jsx and created ScrollableText.js to maintain file consistency between our components -Replaced the CSS scroll animation with a JavaScript-controlled one that maintains absolute constant speed regardless of character length -Scroll speed has been refined for both the song (slow) and artist (slower) titles -AFAIK, the instance where the text occasionally scrolls to far should be resolved - it stops at the lower bound, the ending of the string -Left/right fades appropriately appear and disappear (both sides during movement, when stopping at the end of the string, for each side, the respective fade disappears then reappears once movement starts again)
- Brought back the pause for mouse hover state for scrolling song and artist titles - Removed temporary placeholder text for default song and artist titles used during testing - Brought back the block of code in ScrollableText.js mentioned by Evan and implemented it in a way that is proper and easier to read
feat: Add oscillating scrollable text for long titles/artists Bypassing for the sake of time. All suggestions have been implemented. Tested, RTG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.