Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds three accessibility skills to
.claude/skills/and a short pointer inCLAUDE.md. The skills codify the conventions and review rubrics for the A11y PR Triage workflow that landed in #3465 so they survive across sessions, contributors, and team membership changes.a11y-pr-review— reviewer-facing. Decodes thea11y:*labels the triage workflow applies (buckets 1–4, failure-modes, SC labels) and prescribes the review depth for each.a11y-manifest-discipline— author-facing. The rule for keepingscripts/a11y/manifest.ymlin sync when shipping or re-bucketing a fix doc, plus the bucket framework recap and backfill commands.wcag-audit— auditor-facing. The in-repo distillation of the four verification work shapes, the static-vs-manual decision discipline, inventory practice, verdict logic, severity rubric, and anti-patterns the audit team has hit. The full source artefact lives in the audit team's private workspace; this is the public, auditable version.The
CLAUDE.mdaddition is intentionally minimal — a single paragraph pointing at the three skills. Earlier drafts inlined more guidance; on review of #3465, that pattern was flagged as the wrong place for it. Skills are the right home for procedural knowledge;CLAUDE.mdshould just announce that the system exists.Screenshots (if applicable) 📸
N/A — documentation / agent-tooling change. No UI surfaces.
Design Considerations 🎨
temporalio/cloud-ui. The two variants drift in places — slug conventions, scope enums, the example trailer — because OSS contributors don't have visibility into private tickets, the audit team's private workspace, or the existence of a second repo. Anywhere the two had to differ, the OSS version stays explicit and the private version carries the cross-repo coordination detail.wcag-auditskill is a port, not a replacement. The audit team's process artefact has worked examples that cite specific issue docs (private). That doc is the source of truth; this file is the durable, in-repo distillation that survives team changes. The Status note at the top makes this explicit, including the four criterion rows it has actually been exercised against.Testing 🧪
How was this tested 👻
Specifically:
a11y:broken-refmean?", "how do I add a manifest entry?", "what's the shape of this row's verification work?") to confirm the skill answers it without needing the source artefact.user-invocable: truefrontmatter on all three) and that each one'sdescriptionis specific enough to disambiguate between them.[[wcag-audit]],[[a11y-manifest-discipline]],[[a11y-pr-review]]links resolve to sibling skill slugs.Steps for others to test 🚶🏽♂️🚶🏽♀️
In a Claude Code session in this repo:
/a11y-pr-reviewand ask it to walk a labeled PR — confirm the bucket-to-review-depth mapping is what you'd expect./a11y-manifest-disciplineand ask it to draft an entry for a hypothetical new fix doc — confirm it asks the right field questions and produces a valid YAML row./wcag-auditand ask it which of the four verification work shapes applies to a given matrix row — confirm the trigger criteria are clear enough to choose without flipping a coin.Checklists
Draft Checklist
CLAUDE.mdshortened to a pointer per review of [DT-4048] Add accessibility PR triage and notification helpers #3465.Merge Checklist
user-invocable: true).Issue(s) closed
N/A — internal initiative. Tracked in
temporalio/cloud-ui's issue tracker.Docs
Any docs updates needed?
None. The skills are the docs for this surface;
CLAUDE.mdpoints at them.