Skip to content

Use shared SearchAttributeFilter component in Workflows list view #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurakwhit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use shared SearchAttributeFilter component in Workflows list view #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/search-attribute-filter/filter-bar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
options,
searchAttributes,
id,
statusAttribute,
statusAttribute = 'ExecutionStatus',
onManualSearch,
includeNullConditions,
}: Props = $props();
Expand Down
1 change: 0 additions & 1 deletion src/lib/components/standalone-activities/activities-summary-filter-bar/filter-bar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,5 @@
options={$activitySearchAttributeOptions}
searchAttributes={$activitySearchAttributes}
id="activity"
statusAttribute="ExecutionStatus"
{onManualSearch}
/>
115 changes: 0 additions & 115 deletions src/lib/components/workflow/filter-bar/dropdown-filter-list.svelte
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions src/lib/components/workflow/filter-bar/filter.svelte
View file
Open in desktop

This file was deleted.

53 changes: 17 additions & 36 deletions src/lib/components/workflow/filter-bar/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,21 @@
<script lang="ts">
import Button from '$lib/holocene/button.svelte';
import Icon from '$lib/holocene/icon/icon.svelte';
import Tooltip from '$lib/holocene/tooltip.svelte';
import FilterBar from '$lib/components/search-attribute-filter/filter-bar.svelte';
import { workflowFilters } from '$lib/stores/filters';
import {
searchAttributes,
sortedSearchAttributeOptions,
} from '$lib/stores/search-attributes';
import { refresh } from '$lib/stores/workflows';

import Filter from './filter.svelte';
import ManualQuery from './manual-query.svelte';

let viewManualQuery = $state(false);
const onManualSearch = () => {
$refresh = Date.now();
};
</script>

{#snippet actionToggleButtons()}
<div class="flex items-center gap-1">
<Tooltip text={viewManualQuery ? 'Hide raw query' : 'View raw query'} left>
<Button
variant="ghost"
size="xs"
leadingIcon="json"
active={viewManualQuery}
data-testid="toggle-manual-query"
on:click={() => (viewManualQuery = !viewManualQuery)}
/>
</Tooltip>
</div>
{/snippet}

<div>
<div
class="flex w-full flex-wrap items-center justify-between gap-2 border border-subtle bg-primary p-1.5"
>
<div class="flex grow items-center justify-start gap-4 px-2">
<Icon name="filter-lines" class="text-primary-text h-4 w-4 shrink-0" />
<Filter />
</div>
{@render actionToggleButtons()}
</div>
{#if viewManualQuery}
<ManualQuery />
{/if}
</div>
<FilterBar
filters={workflowFilters}
options={$sortedSearchAttributeOptions}
searchAttributes={$searchAttributes}
id="workflow"
{onManualSearch}
/>
87 changes: 0 additions & 87 deletions src/lib/components/workflow/filter-bar/manual-query.svelte
View file
Open in desktop

This file was deleted.

Loading
Loading