Skip to content

fix(a11y): align DOM order with visual order in mobile bottom-nav (WCAG 1.3.2) #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bilal-karim wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

fix(a11y): align DOM order with visual order in mobile bottom-nav (WCAG 1.3.2) #3441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/lib/components/bottom-nav-links.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@

let { open = false, sections }: Props = $props();

const isNotLastSection = (i: number): boolean => i !== sections.length - 1;
const visualSections = $derived([...sections].reverse());

const isNotLastSection = (i: number): boolean =>
i !== visualSections.length - 1;
</script>

{#if open}
<div
class="flex h-full flex-col-reverse justify-start gap-6 overflow-auto px-4 py-8"
>
{#each sections as section, i (i)}
<div class="flex h-full flex-col justify-start gap-6 overflow-auto px-4 py-8">
{#each visualSections as section, i (i)}
<NavSection navItems={section} />
{#if isNotLastSection(i)}
<hr class="border-subtle" />
Expand Down
Loading