Closed
Conversation
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
3 times, most recently
from
655de14 to
bde2779
Compare
stephanos
commented
Apr 15, 2026
| } | ||
| } | ||
|
|
||
| func RegisterHTTPHandler(options HandlerOptions, logger log.Logger, router *mux.Router) { |
Contributor
Author
There was a problem hiding this comment.
Moved to service/frontend
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
5 times, most recently
from
0bd7e80 to
8f2e203
Compare
stephanos
commented
Apr 15, 2026
|
|
||
| // Small wrapper that does some pre-processing before handing requests over to the Nexus SDK's HTTP handler. | ||
| type NexusHTTPHandler struct { | ||
| type NexusOperationHTTPHandler struct { |
Contributor
Author
There was a problem hiding this comment.
Renamed this to distinguish from completion handler.
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
7 times, most recently
from
da54b6d to
f5d3879
Compare
stephanos
commented
Apr 15, 2026
| } | ||
|
|
||
| type completionHandler struct { | ||
| type CompletionHandler struct { |
Contributor
Author
There was a problem hiding this comment.
Needs to be exported for fx injection; there are alternatives but this is the most direct option.
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
from
f5d3879 to
5daa78d
Compare
stephanos
commented
Apr 15, 2026
| clientVersionChecker: headers.NewDefaultVersionChecker(), | ||
| preProcessErrorsCounter: options.MetricsHandler.Counter(metrics.NexusCompletionRequestPreProcessErrors.Name()), | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
^ this was in RegisterHTTPHandler before
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
from
5daa78d to
381218c
Compare
stephanos
commented
Apr 15, 2026
| // The original HTTP request. | ||
| HTTPRequest *http.Request | ||
| // Decoded Temporal callback token, if present and valid. | ||
| CompletionToken *tokenspb.NexusOperationCompletion |
Contributor
Author
There was a problem hiding this comment.
Moved this up the chain to not have to decode it twice.
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
from
381218c to
ca4c950
Compare
stephanos
commented
Apr 15, 2026
| @@ -0,0 +1,21 @@ | |||
| package nexusoperation | |||
Contributor
Author
There was a problem hiding this comment.
Note sure about the file name; on the SANO feature branch there is frontend.go. But that's for client-facing APIs.
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
4 times, most recently
from
4863bd2 to
1fea9eb
Compare
stephanos
force-pushed
the
stephanos/nexus-completion-refactor
branch
from
1fea9eb to
0021298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Describe what has changed in this PR.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.