Guard against late-arriving polls after worker shutdown#9330
Draft
Guard against late-arriving polls after worker shutdown#9330
Conversation
When CancelOutstandingWorkerPolls is called, the WorkerInstanceKey is cached in a TTL cache (60s default). Any subsequent poll arriving with this key returns empty immediately, preventing task dispatch to a shutting-down worker. This handles the edge case where a poll request was in-flight (already sent by SDK) when ShutdownWorker was called, arriving at the server after the cancellation logic has completed. - Add ShutdownWorkerCacheTTL dynamic config (60s default) - Add shutdownWorkers TTL cache to matchingEngineImpl - Check cache early in PollWorkflowTaskQueue/PollActivityTaskQueue - Add unit tests for cache behavior
rkannan82
force-pushed
the
kannan/shutdown-worker-poll-guard
branch
from
441d5b6 to
5c1df05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
When
CancelOutstandingWorkerPollsis called, theWorkerInstanceKeyis cached in a TTL cache (70s default). Any subsequent poll arriving with this key returns empty immediately, preventing task dispatch to a shutting-down worker.Why?
This handles the edge case where a poll request was in-flight (already sent by SDK) when
ShutdownWorkerwas called, arriving at the server after the cancellation logic has completed. Without this guard, such polls could receive tasks that would never be processed.How did you test it?
Potential risks