Fixing bug in retrieving archived workflows from Google Cloud Store#9329
Open
uromahn wants to merge 3 commits intotemporalio:mainfrom
Open
Fixing bug in retrieving archived workflows from Google Cloud Store#9329uromahn wants to merge 3 commits intotemporalio:mainfrom
uromahn wants to merge 3 commits intotemporalio:mainfrom
Conversation
There is a bug in the visibility-archiver implementation of the Google Cloud archiver. All archived workflows are being retrieved and displayed twice. This change fixes that bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed a bug in the gcloud visibility_archiver.go file and added a new unit test in visibility_archiver_test.go.
Why?
There is a bug in the visibility-archiver implementation of the Google Cloud archiver. All archived workflows are being retrieved and displayed twice. This change fixes that bug.
How did you test it?
Potential risks
No risk since the archiver is completely decoupled from the core functionality.