CHASM: support archetypeID in admin handler#9309
CHASM: support archetypeID in admin handler#9309yycptt wants to merge 2 commits intotemporalio:mainfrom
Conversation
bergundy
left a comment
There was a problem hiding this comment.
Could you also remove the registration of the workflow and scheduler libraries from the other services?
| Usage: "Fully qualified archetype name of the execution", | ||
| DefaultText: chasm.WorkflowArchetype, | ||
| }, | ||
| &cli.UintFlag{ |
There was a problem hiding this comment.
I wonder if anyone is going to use the numeric ID. What's the use case?
There was a problem hiding this comment.
I am thinking If any log message logs the ID or if we are looking at raw persistence records that would be useful.
but I guess I was also thinking: why not? It's optional anyway, and not complicating the logic a lot. The message is also clear re. the behavior. so I couldn't convince myself why not exposing it in tdbg.
I see that we will need it for a while longer but let's make sure we do that soon. |
yeah that will have to wait until next cloud release. I will have the work tracked. |
What changed?
Why?
How did you test it?