Skip to content

CHASM: support archetypeID in admin handler#9309

Open
yycptt wants to merge 2 commits intotemporalio:mainfrom
yycptt:chasm-admin-handler-archetypeID
Open

CHASM: support archetypeID in admin handler#9309
yycptt wants to merge 2 commits intotemporalio:mainfrom
yycptt:chasm-admin-handler-archetypeID

Conversation

@yycptt
Copy link
Member

@yycptt yycptt commented Feb 12, 2026

What changed?

  • Accept archetypeID in admin API requests

Why?

  • With this we no longer need to register chasm components to worker service, which currently performs an archetypeID to name conversion before calling admin apis.
  • For backward compatibility, we can only stop registering chasm components to worker service starting from next cloud release.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@yycptt yycptt requested a review from awln-temporal February 12, 2026 22:30
@yycptt yycptt requested review from a team as code owners February 12, 2026 22:30
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the registration of the workflow and scheduler libraries from the other services?

Usage: "Fully qualified archetype name of the execution",
DefaultText: chasm.WorkflowArchetype,
},
&cli.UintFlag{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if anyone is going to use the numeric ID. What's the use case?

Copy link
Member Author

@yycptt yycptt Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking If any log message logs the ID or if we are looking at raw persistence records that would be useful.

but I guess I was also thinking: why not? It's optional anyway, and not complicating the logic a lot. The message is also clear re. the behavior. so I couldn't convince myself why not exposing it in tdbg.

@bergundy
Copy link
Member

Could you also remove the registration of the workflow and scheduler libraries from the other services?

I see that we will need it for a while longer but let's make sure we do that soon.
We will want to break up all of the libraries into the component only parts and other parts with more dependencies for registration in the frontend to handle visibility APIs.

@yycptt
Copy link
Member Author

yycptt commented Feb 13, 2026

Could you also remove the registration of the workflow and scheduler libraries from the other services?

I see that we will need it for a while longer but let's make sure we do that soon. We will want to break up all of the libraries into the component only parts and other parts with more dependencies for registration in the frontend to handle visibility APIs.

yeah that will have to wait until next cloud release. I will have the work tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants