docs(release): Update publishing procedure#1340
Open
mjameswh wants to merge 11 commits intotemporalio:mainfrom
Open
docs(release): Update publishing procedure#1340mjameswh wants to merge 11 commits intotemporalio:mainfrom
mjameswh wants to merge 11 commits intotemporalio:mainfrom
Conversation
mjameswh
changed the title
mjameswh
commented
Jan 9, 2025
Contributor
Author
mjameswh
left a comment
mjameswh
left a comment
There was a problem hiding this comment.
Sample repo now uses PNPM
|
|
||
| gh repo set-default temporalio/sdk-typescript | ||
| gh pr create | ||
| # Get PR approved and merged |
Member
There was a problem hiding this comment.
We need to add a pause point here so the user has time to get the PR merged. Right now it will immediately checkout main before the PR has a chance to merge.
| set -euo pipefail | ||
|
|
||
| local workdir=$( mktemp -d -t sdk-typescript-release ) | ||
| trap 'cd / && rm -rf "$workdir"' EXIT |
Member
There was a problem hiding this comment.
This is a little aggressive, we might want to just suggest to end user to clean up. If a pnpm publish fails, we lose all progress and have to start from 0
| exit 1 | ||
| fi | ||
|
|
||
| git clone --branch $source_branch --depth 1 --shallow-submodules --recurse-submodules https://github.com/temporalio/sdk-typescript.git |
Member
There was a problem hiding this comment.
With GitHub removing password auth for HTTPS Git ops using SSH is a easier IMO than creating and using a PAT.
Suggested change
| git clone --branch $source_branch --depth 1 --shallow-submodules --recurse-submodules https://github.com/temporalio/sdk-typescript.git | |
| git clone --branch $source_branch --depth 1 --shallow-submodules --recurse-submodules org-56493103@github.com:temporalio/sdk-typescript.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Notes
These instructions reflect the current, de facto process, not the desired long term vision of how we should be releasing this project.