Plumb through option for configuring DNS resolver#1501
Open
Sushisource wants to merge 2 commits intomainfrom
Open
Plumb through option for configuring DNS resolver#1501Sushisource wants to merge 2 commits intomainfrom
Sushisource wants to merge 2 commits intomainfrom
Conversation
cconstable
reviewed
May 8, 2026
Comment on lines
+248
to
+252
| let dns_load_balancing = if has_proxy { | ||
| None | ||
| } else { | ||
| self.dns_load_balancing_config.map(Into::into) | ||
| }; |
Contributor
There was a problem hiding this comment.
this might be handled elsewhere but what if a user has configured both a proxy and a dns balancing policy? do we just silently drop the config? do we log a warning? mostly asking out of curiosity.
cconstable
reviewed
May 8, 2026
| assert bridge_config.dns_load_balancing_config.resolution_interval_millis == 5000 | ||
|
|
||
|
|
||
| def test_connect_config_dns_load_balancing_disabled(): |
Contributor
There was a problem hiding this comment.
related to my question about the proxy taking precedence over dns config: is that behavior tested in core?
Contributor
|
lgtm 👍 do the other sdks need this update? seems like a useful config to have. |
cconstable
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Plumb through the DNS resolver options to core
Why?
Nice to be able to disable this
Checklist
Closes
How was this tested:
Added config unit test
Any docs updates needed?