Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
flippedcoder
force-pushed
the
mm/rust-sdk
branch
from
658bb46 to
5599ed2
Compare
flippedcoder
force-pushed
the
mm/rust-sdk
branch
from
5599ed2 to
8ed93c7
Compare
flippedcoder
force-pushed
the
mm/rust-sdk
branch
2 times, most recently
from
adb4a7a to
3d673be
Compare
flippedcoder
force-pushed
the
mm/rust-sdk
branch
from
3d673be to
d6eb0bd
Compare
flippedcoder
force-pushed
the
mm/rust-sdk
branch
from
d6eb0bd to
bcd3c34
Compare
flippedcoder
force-pushed
the
mm/rust-sdk
branch
from
2cb46fa to
de03821
Compare
Comment on lines
+265
to
+266
| let connection_options = | ||
| ConnectionOptions::new(Url::from_str("http://localhost:7233")?).build(); |
Member
There was a problem hiding this comment.
It might make sense to funnel users towards envconfig:
https://github.com/temporalio/sdk-core/blob/00d3888adc36d4fab36cca3fdd8426c199ab669d/crates/sdk/examples/hello_world/worker.rs#L18
Comment on lines
+26
to
+40
| #[activities] | ||
| impl GreetingActivities { | ||
| #[activity] | ||
| pub async fn greet(_ctx: ActivityContext, name: String) -> Result<String, ActivityError> { | ||
| Ok(format!("Hello, {}!", name)) | ||
| } | ||
|
|
||
| #[activity] | ||
| pub async fn send_notification(_ctx: ActivityContext, message: String) -> Result<(), ActivityError> { | ||
| println!("Sending notification: {}", message); | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| pub struct GreetingActivities; |
Member
There was a problem hiding this comment.
It is awkward to declare the struct after the implementation
Suggested change
| #[activities] | |
| impl GreetingActivities { | |
| #[activity] | |
| pub async fn greet(_ctx: ActivityContext, name: String) -> Result<String, ActivityError> { | |
| Ok(format!("Hello, {}!", name)) | |
| } | |
| #[activity] | |
| pub async fn send_notification(_ctx: ActivityContext, message: String) -> Result<(), ActivityError> { | |
| println!("Sending notification: {}", message); | |
| Ok(()) | |
| } | |
| } | |
| pub struct GreetingActivities; | |
| pub struct GreetingActivities; | |
| #[activities] | |
| impl GreetingActivities { | |
| #[activity] | |
| pub async fn greet(_ctx: ActivityContext, name: String) -> Result<String, ActivityError> { | |
| Ok(format!("Hello, {}!", name)) | |
| } | |
| #[activity] | |
| pub async fn send_notification(_ctx: ActivityContext, message: String) -> Result<(), ActivityError> { | |
| println!("Sending notification: {}", message); | |
| Ok(()) | |
| } | |
| } |
|
|
||
| **How to define Activity parameters using the Temporal Rust SDK.** | ||
|
|
||
| There is no explicit limit to the total number of parameters that an [Activity Definition](/activity-definition) may support. However, there is a limit to the total size of the data that ends up encoded into a gRPC message Payload. |
Member
There was a problem hiding this comment.
For Rust we actually have a hard cap of 6 parameters for activities.
|
|
||
| We recommend that you use a single struct as an argument that wraps all the application data passed to Activities. This way you can change what data is passed to the Activity without breaking the function signature. | ||
|
|
||
| Activity parameters must be serializable and deserializable using serde. Use `#[derive(Serialize, Deserialize)]` on your data types: |
Member
There was a problem hiding this comment.
This isn't a hard requirement, but implementing the serde traits are the easiest way to ensure they work. If they have a protobuf message they can leverage ProstSerializable for encoding without implementing the serde traits.
I am actively working on improving the ergonomics of using protobuf instead of serde, so I don't have a good sample yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the docs for the Rust SDK.
Notes to reviewers
┆Attachments: EDU-6184 feat(rust): rust sdk docs