Fix typed search attributes not printing in text mode for schedules#1060
Open
NasitSony wants to merge 1 commit into
Open
Fix typed search attributes not printing in text mode for schedules#1060NasitSony wants to merge 1 commit into
NasitSony wants to merge 1 commit into
Conversation
Convert SearchAttributes using CustomJSONMarshalOptions before assigning to printableSchedule, ensuring typed fields serialize correctly through standard json.Marshal. Fixes temporalio#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert SearchAttributes using CustomJSONMarshalOptions before assigning to printableSchedule, ensuring typed fields serialize correctly through standard json.Marshal.
Fixes #590
Related issues
Closes #590
What changed?
Convert
SearchAttributesfield inprintableSchedulefrom*commonpb.SearchAttributestomap[string]interface{}. AddedsearchAttributesToMaphelper usingtemporalproto.CustomJSONMarshalOptionsto correctly serialize typed search attributes in text mode.Checklist
Stability
Design
Tests
TestSchedule_CreateDescribe_SearchAttributes_Memocovers this (currently skipped pending this fix)Manual tests
Setup
temporal server start-dev --headless
temporal operator search-attribute create --name CustomKeywordField --type Keyword
temporal schedule create -s foo --task-queue foo --type foo --workflow-id asdf --interval 10d --search-attribute CustomKeywordField="schedule-string-val"
Happy path
$ temporal schedule describe -s foo
Action {...,"TypedSearchAttributes":{"CustomKeywordField":"schedule-string-val"},...}
Error case
N/A — bug fix only